start: Avoid string concatenation in inline asm.
#21056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrp
force-pushed
the
start-fix-precedence
branch
from
abb0bb4
to
638be20
Compare
|
Done, and also included a workaround in the LLVM backend to ensure that frame pointers don't get used in naked functions. |
alexrp
changed the title
start: Fix ++ usage in inline asm string construction.start: Avoid string concatenation in inline asm.
andrewrk
requested changes
Aug 14, 2024
alexrp
force-pushed
the
start-fix-precedence
branch
from
638be20
to
c37f00e
Compare
|
Folded #21070 into this one and removed the |
For csky, we can just always do the gb initialization. For riscv, the gp code is temporarily pulled above the main switch until the blocking issue is resolved.
alexrp
force-pushed
the
start-fix-precedence
branch
from
c37f00e
to
7a8e86e
Compare
|
Thank you, looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the operator precedence wrong.
For csky, there are currently some LLVM issues blocking full compilation, so that mistake slipped through rather unsurprisingly. For riscv, I first added the
gpinitialization code unconditionally and tested it, but then I added the condition to exclude that code in self-hosted and neglected to actually test it with LLVM afterwards. The result was that it worked fine with the self-hosted backend, but not so with LLVM (which we have no CI coverage for due to #18872).